Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix seeds for more tests #6460

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix seeds for more tests #6460

wants to merge 7 commits into from
+27 −32

Conversation

astralcai
Copy link
Contributor

@astralcai astralcai commented Oct 28, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@astralcai astralcai changed the title Fix seeds for two more tests Fix seeds for more tests Oct 28, 2024
JerryChen97
JerryChen97 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@JerryChen97 JerryChen97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@astralcai astralcai added the do not merge ⚠️ Do not merge the pull request until this label is removed label Oct 28, 2024
@astralcai
Copy link
Contributor Author

Keeping this PR open for a while as more stochastic failures occur on master.

@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.39%. Comparing base (661dd52) to head (3a0983e).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6460   +/-   ##
=======================================
  Coverage   99.38%   99.39%           
=======================================
  Files         452      452           
  Lines       42789    42787    -2     
=======================================
- Hits        42527    42526    -1     
+ Misses        262      261    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JerryChen97 JerryChen97 JerryChen97 approved these changes

@PietropaoloFrisoni PietropaoloFrisoni PietropaoloFrisoni approved these changes

Assignees
No one assigned
Labels
do not merge ⚠️ Do not merge the pull request until this label is removed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@astralcai @JerryChen97 @PietropaoloFrisoni