Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved issue #337 (this fix also #267) #357

Merged
merged 9 commits into from
Dec 14, 2023

Conversation

fran-scala
Copy link
Contributor

This change to runtime_devices.py avoid negative probabilities in quasi probability distributions (issue #337). It also includes the changes proposed in issue #267 which are still not implemented in the plugin.

@lillian542 lillian542 self-requested a review December 7, 2023 19:32
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8be0ae) 100.00% compared to head (723d193) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #357   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          322       322           
=========================================
  Hits           322       322           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great! I left a couple of comments, and you'll need to remove the whitespaces to make the CodeFactor bot happy, but I think this is nearly done 🎉

Do add this as a bug-fix (or 2 or 3...) to the change-log, and don't forget to include your name as a contributor there as well!

pennylane_qiskit/runtime_devices.py Outdated Show resolved Hide resolved
pennylane_qiskit/runtime_devices.py Outdated Show resolved Hide resolved
Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @fran-scala! Everything looks good to me, just missing a blank line at the end of the file to appease the bot 🤖

@lillian542
Copy link
Contributor

It looks like you also need to run black -l 100 pennylane_qiskit before the formatting check will pass

@fran-scala
Copy link
Contributor Author

Now everything should be ok!

@lillian542 lillian542 merged commit 55f5df4 into PennyLaneAI:master Dec 14, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants