-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solved issue #337 (this fix also #267) #357
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #357 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 322 322
=========================================
Hits 322 322 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great! I left a couple of comments, and you'll need to remove the whitespaces to make the CodeFactor bot happy, but I think this is nearly done 🎉
Do add this as a bug-fix (or 2 or 3...) to the change-log, and don't forget to include your name as a contributor there as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @fran-scala! Everything looks good to me, just missing a blank line at the end of the file to appease the bot 🤖
It looks like you also need to run |
Now everything should be ok! |
This change to
runtime_devices.py
avoid negative probabilities in quasi probability distributions (issue #337). It also includes the changes proposed in issue #267 which are still not implemented in the plugin.