Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instructions for LT and LGPU #957

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

multiphaseCFD
Copy link
Member

@multiphaseCFD multiphaseCFD commented Oct 23, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

[sc-76616]

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@multiphaseCFD multiphaseCFD marked this pull request as ready for review October 23, 2024 13:31
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.58%. Comparing base (156a035) to head (45ee609).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (156a035) and HEAD (45ee609). Click for more details.

HEAD has 87 uploads less than BASE
Flag BASE (156a035) HEAD (45ee609)
93 6
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #957       +/-   ##
===========================================
- Coverage   96.99%   53.58%   -43.41%     
===========================================
  Files         215       28      -187     
  Lines       31805     2495    -29310     
===========================================
- Hits        30849     1337    -29512     
- Misses        956     1158      +202     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@LuisAlfredoNu LuisAlfredoNu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @multiphaseCFD
Just one comment for LTensor

README.rst Show resolved Hide resolved
multiphaseCFD and others added 2 commits October 24, 2024 11:15
Co-authored-by: Joseph Lee <[email protected]>
Co-authored-by: Joseph Lee <[email protected]>
Copy link
Contributor

@LuisAlfredoNu LuisAlfredoNu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you @multiphaseCFD
I just left a suggestion.

Copy link
Contributor

@josephleekl josephleekl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks Shuli!

@multiphaseCFD multiphaseCFD merged commit 6d91c9a into master Oct 25, 2024
75 of 76 checks passed
@multiphaseCFD multiphaseCFD deleted the update_lt_lgpu_install_docs branch October 25, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants