-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize memory peak for _preprocess_state_vector
in LightningTensor
#943
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #943 +/- ##
==========================================
- Coverage 96.24% 95.16% -1.09%
==========================================
Files 215 98 -117
Lines 29460 11922 -17538
==========================================
- Hits 28353 11345 -17008
+ Misses 1107 577 -530 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to ignore me if these comments are being a blocker. Otherwise, just looking for some clarifications :)
Co-authored-by: Lee James O'Riordan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @LuisAlfredoNu, for the very comprehensive explanation and in-office discussion. Happy to approve!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
After profiling Lightning Tensor with scalene profiler. We found a bottleneck of memory in the function
_preprocess_state_vector
(code) which allocates 3 arrays with dimension 2 ** wires * wires.Description of the Change:
Optimize the cartesian product to reduce the amount of memory necessary to set the
StatePrep
with LTensorBenefits:
Reduce by half the peak of memory for large systems close to 30 qubit
Benchmark code
Possible Drawbacks:
This change reduces readability but with a good improvement.
Related GitHub Issues:
[sc-75692]