Add native N-control gate support to lightning.gpu #938
+986
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multiphaseCFD
changed the title
5 tasks
josephleekl
reviewed
Oct 24, 2024
josephleekl
reviewed
Oct 24, 2024
josephleekl
reviewed
Oct 24, 2024
josephleekl
reviewed
Oct 24, 2024
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaManaged.hpp
Show resolved
Hide resolved
josephleekl
reviewed
Oct 24, 2024
josephleekl
reviewed
Oct 24, 2024
josephleekl
reviewed
Oct 24, 2024
josephleekl
reviewed
Oct 24, 2024
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaManaged.hpp
Outdated
Show resolved
Hide resolved
josephleekl
reviewed
Oct 24, 2024
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaManaged.hpp
Outdated
Show resolved
Hide resolved
josephleekl
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Thank you very much @multiphaseCFD
It is super nice to have this feature.
Only a few questions and suggestions 😄
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaManaged.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaManaged.hpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaManaged.hpp
Show resolved
Hide resolved
...tning/core/src/simulators/lightning_gpu/gates/tests/Test_StateVectorCudaManaged_NonParam.cpp
Show resolved
Hide resolved
...tning/core/src/simulators/lightning_gpu/gates/tests/Test_StateVectorCudaManaged_NonParam.cpp
Show resolved
Hide resolved
LuisAlfredoNu
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Thank you @multiphaseCFD
Really nice work!
This will improve the functionality and the performance of LGPU.
Just a few questions
| const auto gate_name = | ||
| std::string(lookup(Constant::controlled_gate_names, gate_op)); | ||
| const std::string doc = "Apply the " + gate_name + " gate."; | ||
| auto func = [gate_name = gate_name]( |
There was a problem hiding this comment.
Suggested change
| auto func = [gate_name = gate_name]( | |
| auto func = [&gate_name]( |
Comment on lines
+408
to
+412
| auto &gateMap = | ||
| cuGates::DynamicGateDataAccess<PrecisionT>::getInstance(); | ||
| auto &&matrix_cu = gateMap.getGateData(opName, params); | ||
|
|
||
| gate_cache_.add_gate(opName, params[0], matrix_cu); |
There was a problem hiding this comment.
Could you explain to us why we use here auto & and auto &&, please? We can not guess the reason for this. @josephleekl
Comment on lines
+341
to
+344
| # TODO: To move this line to the _apply_lightning_controlled method once the MPI backend supports controlled gates natively | ||
| raise DeviceError( | ||
| "Lightning-GPU-MPI does not support Controlled GlobalPhase gates." | ||
| ) |
There was a problem hiding this comment.
Is this feature close to being added? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
[SC-73168]
[SC-75443] (duplicate)
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: