Add native setStateVector support to lightning.gpu
#930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multiphaseCFD
changed the title
_apply_state_vector cpp support_apply_state_vector cpp support to lightning.tensor via setStateVector
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #930 +/- ##
==========================================
+ Coverage 96.41% 96.96% +0.55%
==========================================
Files 215 132 -83
Lines 28143 16993 -11150
==========================================
- Hits 27133 16478 -10655
+ Misses 1010 515 -495 ☔ View full report in Codecov by Sentry. |
multiphaseCFD
requested review from
maliasadi,
AmintorDusko,
josephleekl and
LuisAlfredoNu
multiphaseCFD
changed the title
_apply_state_vector cpp support to lightning.tensor via setStateVectorsetStateVector support to lightning.gpu
multiphaseCFD
added
ci:use-multi-gpu-runner
maliasadi
approved these changes
Oct 2, 2024
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaMPI.hpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaMPI.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaManaged.hpp
Outdated
Show resolved
Hide resolved
LuisAlfredoNu
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
LGTM. Just one comment but feel free to ignore it.
Thank you @multiphaseCFD
Nice work!
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaMPI.hpp
Show resolved
Hide resolved
multiphaseCFD
added a commit
that referenced
this pull request
Oct 8, 2024
Please complete the following checklist when submitting a PR:
- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
[`tests`](../tests) directory!
- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [x] Ensure that the test suite passes, by running `make test`.
- [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
change, and including a link back to the PR.
- [x] Ensure that code is properly formatted by running `make format`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:**
[SC-74668]
`setStateVector` via state and wires is supported in the C++ layer in
`lightning.gpu`
**Description of the Change:**
**Benefits:**
**Possible Drawbacks:**
**Related GitHub Issues:**
---------
Co-authored-by: ringo-but-quantum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
[SC-74668]
setStateVectorvia state and wires is supported in the C++ layer inlightning.gpuDescription of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: