Remove magic numbers in Lightning stopping_conditions #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multiphaseCFD
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Thanks @maliasadi . LGTM. Don't forget to add entry to the changelog.
maliasadi
requested review from
multiphaseCFD,
LuisAlfredoNu and
AmintorDusko
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #926 +/- ##
===========================================
- Coverage 97.23% 69.82% -27.42%
===========================================
Files 214 24 -190
Lines 29802 2283 -27519
===========================================
- Hits 28978 1594 -27384
+ Misses 824 689 -135 ☔ View full report in Codecov by Sentry. |
multiphaseCFD
approved these changes
Sep 27, 2024
AmintorDusko
approved these changes
Sep 27, 2024
LuisAlfredoNu
requested changes
Sep 27, 2024
maliasadi
added
ci:use-multi-gpu-runner
LuisAlfredoNu
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-74414]