Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the missing lightning_tensor device in PL/Lightning stable/stable #766

Merged
merged 9 commits into from
Jun 18, 2024

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented Jun 18, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
The plugin matrix for PL/Lightning stable/stable is currently failing due to the missing lightning_tensor device in the stable version. Check https://github.com/PennyLaneAI/pennylane-lightning/actions/runs/9558259457. This PR adds a temporary patch to skip the build & test for stable/stable until the next release.

Description of the Change:

Benefits:
Pass stable/stable plugin matrix https://github.com/PennyLaneAI/pennylane-lightning/actions/runs/9569756079

Possible Drawbacks:

Related GitHub Issues:

[sc-66324]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.85%. Comparing base (476cac2) to head (73c9e99).
Report is 92 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (476cac2) and HEAD (73c9e99). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (476cac2) HEAD (73c9e99)
12 11
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #766       +/-   ##
===========================================
- Coverage   98.41%   65.85%   -32.57%     
===========================================
  Files         109       30       -79     
  Lines       15696     3933    -11763     
===========================================
- Hits        15448     2590    -12858     
- Misses        248     1343     +1095     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better now! Thanks!

Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now ;) Thanks @maliasadi .

@maliasadi
Copy link
Member Author

maliasadi commented Jun 18, 2024

@maliasadi maliasadi merged commit 73bfee7 into master Jun 18, 2024
86 of 88 checks passed
@maliasadi maliasadi deleted the matrix-stable-stable-ltn branch June 18, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants