-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the missing lightning_tensor device in PL/Lightning stable/stable #766
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #766 +/- ##
===========================================
- Coverage 98.41% 65.85% -32.57%
===========================================
Files 109 30 -79
Lines 15696 3933 -11763
===========================================
- Hits 15448 2590 -12858
- Misses 248 1343 +1095 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better now! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now ;) Thanks @maliasadi .
Thanks folks @vincentmr @AmintorDusko Still waiting for the CI https://github.com/PennyLaneAI/pennylane-lightning/actions/runs/9571217404 |
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
The plugin matrix for PL/Lightning stable/stable is currently failing due to the missing
lightning_tensor
device in the stable version. Check https://github.com/PennyLaneAI/pennylane-lightning/actions/runs/9558259457. This PR adds a temporary patch to skip the build & test for stable/stable until the next release.Description of the Change:
Benefits:
Pass stable/stable plugin matrix https://github.com/PennyLaneAI/pennylane-lightning/actions/runs/9569756079
Possible Drawbacks:
Related GitHub Issues:
[sc-66324]