Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toml files with non_commuting_observables #764

Merged
merged 8 commits into from
Jun 18, 2024
Merged

Conversation

lillian542
Copy link
Contributor

Context:
Catalyst is adding non_commuting_observables as a flag in the TOML file, and conditionally applying the split_non_commuting transform in the QJIT device preprocessing if the backend doesn't allow non-commuting observables.

Description of the Change:
Update the lightning TOML files to indicate that non-commuting observables are supported.

Benefits:
Lightning stays consistent with the changes in this PR

@lillian542 lillian542 changed the title Update toml files with non_commuting_observables [WIP] Update toml files with non_commuting_observables Jun 17, 2024
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.50%. Comparing base (a790d02) to head (d8c71f3).
Report is 94 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (a790d02) and HEAD (d8c71f3). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (a790d02) HEAD (d8c71f3)
10 7
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #764      +/-   ##
==========================================
- Coverage   94.29%   86.50%   -7.79%     
==========================================
  Files         109       17      -92     
  Lines       15678     1904   -13774     
==========================================
- Hits        14783     1647   -13136     
+ Misses        895      257     -638     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lillian542 lillian542 changed the title [WIP] Update toml files with non_commuting_observables Update toml files with non_commuting_observables Jun 17, 2024
@lillian542
Copy link
Contributor Author

[sc-60186]

@erick-xanadu erick-xanadu requested a review from a team June 18, 2024 13:45
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cheers @lillian542 .

@lillian542 lillian542 merged commit 9598b09 into master Jun 18, 2024
66 of 67 checks passed
@lillian542 lillian542 deleted the update_tomls branch June 18, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants