Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Conditional.then_op usage to Conditional.base #752

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

mudit2812
Copy link
Contributor

New work in Pennylane removed Conditional.then_op in favour of Conditional.base. This PR updates lightning to use the new attribute.

.github/CHANGELOG.md Outdated Show resolved Hide resolved
@mudit2812 mudit2812 added the ci:build_wheels Activate wheel building. label Jun 6, 2024
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mudit2812!

Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @mudit2812 !

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.87%. Comparing base (d8baf5a) to head (f990433).
Report is 82 commits behind head on master.

Files with missing lines Patch % Lines
...ane_lightning/lightning_kokkos/lightning_kokkos.py 0.00% 1 Missing ⚠️
...nnylane_lightning/lightning_qubit/_state_vector.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (d8baf5a) and HEAD (f990433). Click for more details.

HEAD has 21 uploads less than BASE
Flag BASE (d8baf5a) HEAD (f990433)
25 4
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #752       +/-   ##
===========================================
- Coverage   95.21%   27.87%   -67.35%     
===========================================
  Files         120       15      -105     
  Lines       17504     1729    -15775     
===========================================
- Hits        16667      482    -16185     
- Misses        837     1247      +410     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mudit2812 mudit2812 merged commit 344ae5a into master Jun 6, 2024
74 of 76 checks passed
@mudit2812 mudit2812 deleted the cond-symbolic branch June 6, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants