Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence warnings for NDPermuter file #750

Merged
merged 5 commits into from
Jun 3, 2024
Merged

Silence warnings for NDPermuter file #750

merged 5 commits into from
Jun 3, 2024

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Jun 3, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: This silences the warnings issued from codefactor for the NDPermuter class.

Description of the Change: As above.

Benefits: Prevents false warnings in other PRs

Possible Drawbacks: May miss opportunity for improvements to this class.

Related GitHub Issues:

Copy link
Contributor

github-actions bot commented Jun 3, 2024

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@mlxd mlxd marked this pull request as ready for review June 3, 2024 14:58
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mlxd !

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.51%. Comparing base (6ca460a) to head (0240cda).
Report is 83 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
+ Coverage   97.99%   98.51%   +0.52%     
==========================================
  Files          90      102      +12     
  Lines       13701    14861    +1160     
  Branches      336        0     -336     
==========================================
+ Hits        13426    14640    +1214     
+ Misses        275      221      -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlxd mlxd merged commit 40ce6f8 into master Jun 3, 2024
92 checks passed
@mlxd mlxd deleted the ndpermuter_silence branch June 3, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants