Add support for C(BlockEncode) #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #743 +/- ##
===========================================
- Coverage 90.45% 70.57% -19.89%
===========================================
Files 81 15 -66
Lines 11672 1716 -9956
===========================================
- Hits 10558 1211 -9347
+ Misses 1114 505 -609 ☔ View full report in Codecov by Sentry. |
|
Could you please port this change? We have this --exitfirst merged by mistake. |
vincentmr
reviewed
May 29, 2024
There was a problem hiding this comment.
Thanks @maliasadi , just a couple questions but looks good to me.
dime10
reviewed
May 30, 2024
maliasadi
added
ci:use-multi-gpu-runner
multiphaseCFD
approved these changes
May 31, 2024
dime10
added a commit
to PennyLaneAI/catalyst
that referenced
this pull request
Jun 18, 2024
This PR aims to remove obsolete TOML related code and also resolve incompatibilities with the latest lightning device versions. - The verifier is relaxed to only test agreement of basic gates (no adjoint/control) between the toml and python device spec. - This is needed to resolve the overlapping gate issue introduced by PennyLaneAI/pennylane-lightning#743 - and also allows removing the patch for Lightning Kokkos that exists solely to satisfy the verifier. - The obsolete toml files in the catalyst repo for lightning devices is also removed. - MCMs are marked as un-invertible and un-controllable, since they are non-unitary. Requires: PennyLaneAI/pennylane-lightning#758 [sc-65114]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
To test the QSVT workflow with Lightning devices, we need support for
C(BlockEncode). This PR adds this support via applying the underlying unitary matrix; including python tests to check the correctness ofBlockEncodeandC(BlockEncode)and updating the device toml files to maintain the support in Catalyst.Description of the Change:
Benefits:
Support
C(BlockEncode).Possible Drawbacks:
Related GitHub Issues:
[sc-64361]