Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert default.tensor to lightning.tensor. #730

Merged
merged 5 commits into from
May 15, 2024

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented May 15, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:
Revert default.tensor to lightning.tensor.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@vincentmr vincentmr marked this pull request as ready for review May 15, 2024 18:30
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @vincentmr !

Copy link
Contributor

@PietropaoloFrisoni PietropaoloFrisoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @vincentmr

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.95%. Comparing base (e535094) to head (60a734d).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #730       +/-   ##
===========================================
- Coverage   93.70%   56.95%   -36.76%     
===========================================
  Files          67       16       -51     
  Lines        9947     1840     -8107     
===========================================
- Hits         9321     1048     -8273     
- Misses        626      792      +166     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr merged commit 628d47e into master May 15, 2024
64 checks passed
@vincentmr vincentmr deleted the feature/revert_lightning_tensor branch May 15, 2024 19:33
multiphaseCFD pushed a commit that referenced this pull request May 16, 2024
* Revert default.tensor to lightning.tensor.

* Auto update version from '0.37.0-dev11' to '0.37.0-dev12'

* Update changelog.

* Auto update version from '0.37.0-dev12' to '0.37.0-dev13'

---------

Co-authored-by: ringo-but-quantum <[email protected]>
@vincentmr
Copy link
Contributor Author

[sc-63450]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants