-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin autoray < 0.6.10 #726
Pin autoray < 0.6.10 #726
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #726 +/- ##
===========================================
- Coverage 91.58% 68.80% -22.79%
===========================================
Files 91 16 -75
Lines 14524 1840 -12684
===========================================
- Hits 13302 1266 -12036
+ Misses 1222 574 -648 ☔ View full report in Codecov by Sentry. |
The merge of this PR is currently blocked by PennyLaneAI/pennylane#5595 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @maliasadi!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @maliasadi .
Shall we revert this PR now that autoray |
I think so, plus @dwierichs has a patch PR in PennyLane which should fix the issue in all versions. |
Ah, wait! 0.6.10 will not be fixed, the PR just fixes a complementary problem in 0.6.10 that is not fixed by 0.6.11 itself! |
CIs currently are failing due to jcmgray/autoray#23, we pin to the previous version to pass CIs.