Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin autoray < 0.6.10 #726

Merged
merged 3 commits into from
May 14, 2024
Merged

Pin autoray < 0.6.10 #726

merged 3 commits into from
May 14, 2024

Conversation

maliasadi
Copy link
Member

CIs currently are failing due to jcmgray/autoray#23, we pin to the previous version to pass CIs.

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (1036b83) to head (09299ed).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #726       +/-   ##
===========================================
- Coverage   91.58%   68.80%   -22.79%     
===========================================
  Files          91       16       -75     
  Lines       14524     1840    -12684     
===========================================
- Hits        13302     1266    -12036     
+ Misses       1222      574      -648     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maliasadi
Copy link
Member Author

The merge of this PR is currently blocked by PennyLaneAI/pennylane#5595

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @maliasadi!

@maliasadi maliasadi marked this pull request as ready for review May 14, 2024 14:14
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @maliasadi .

@AmintorDusko AmintorDusko changed the title Pin autoray != 0.6.10 Pin autoray < 0.6.10 May 14, 2024
@maliasadi maliasadi added the ci:build_wheels Activate wheel building. label May 14, 2024
@maliasadi maliasadi merged commit 29fa26c into master May 14, 2024
80 of 81 checks passed
@maliasadi maliasadi deleted the downgrade_autoray branch May 14, 2024 18:04
@trbromley
Copy link
Contributor

Shall we revert this PR now that autoray 0.6.11 is out?

@vincentmr
Copy link
Contributor

I think so, plus @dwierichs has a patch PR in PennyLane which should fix the issue in all versions.

@dwierichs
Copy link

Ah, wait! 0.6.10 will not be fixed, the PR just fixes a complementary problem in 0.6.10 that is not fixed by 0.6.11 itself!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants