-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default.tensor
to setup.py
#719
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mudit --- can we confirm when building this as a wheel the new folders/files are also included?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #719 +/- ##
==========================================
- Coverage 95.70% 93.67% -2.03%
==========================================
Files 91 16 -75
Lines 14054 1835 -12219
==========================================
- Hits 13450 1719 -11731
+ Misses 604 116 -488 ☔ View full report in Codecov by Sentry. |
[sc-61741] |
This is obviously a statistical fluctuation. Codecov keeps complaining, but at this point I am not surprised |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to replace the following too?
pennylane_lightning/lightning_tensor/backends/quimb/_mps.py: """A function that determines if an operation is supported by ``lightning.tensor`` for this interface."""
pennylane_lightning/lightning_tensor/backends/quimb/_mps.py: """A function that determines if an observable is supported by ``lightning.tensor`` for this interface."""
pennylane_lightning/lightning_tensor/lightning_tensor.py: """A function that determines whether or not a backend is supported by ``lightning.tensor``."""
pennylane_lightning/lightning_tensor/lightning_tensor.py: """A function that determines whether or not a method is supported by ``lightning.tensor``."""
Where is this from? |
I was looking for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No more concerns from my side. Thanks @mudit2812
Feel free to merge once all CI runs are green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @mudit2812 .
As name says.
default.tensor
is the updated name of the tensor network device with thequimb
backend. The new change installs it along withlightning.qubit
as there are no non-python dependencies to get the device to work.name
attribute to returndefault.tensor
instead oflightning.tensor
.default.tensor
instead ofLightningTensor
orlightning.tensor
.