Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NonParametric & Parametric Gates support to Lightning.Tensor #718

Merged
merged 132 commits into from
May 28, 2024

Conversation

multiphaseCFD
Copy link
Member

@multiphaseCFD multiphaseCFD commented May 8, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Add gate support to cutensornet backed lightning.tensor. Note that applyOperations in the cutensornet backed backends only appends gate tensors to the compute graph.

[SC-61954] & [SC-61956]

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@multiphaseCFD multiphaseCFD requested review from AmintorDusko and maliasadi and removed request for maliasadi and AmintorDusko May 23, 2024 15:58
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Happy to discuss obs and measurements support in the next PR 🚀

@multiphaseCFD multiphaseCFD requested review from mlxd and removed request for mlxd May 24, 2024 12:45
@multiphaseCFD multiphaseCFD requested review from mlxd and removed request for mlxd May 27, 2024 12:44
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @multiphaseCFD , looking good!

@mlxd mlxd merged commit 81870b7 into master May 28, 2024
108 of 109 checks passed
@mlxd mlxd deleted the add_LTensor_nonParam_gate branch May 28, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building. ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants