Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: compatibility workflows #699

Merged
merged 8 commits into from
Apr 26, 2024
Merged

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Apr 26, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
Compatibility workflows are broken following #695 .

Description of the Change:
Fix the paths in the compat workflows.
More robust concurrency checks (e.g. we don't want a PR cancelling compat cron jobs and vice versa).

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (8b131ca) to head (0cc5c57).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #699      +/-   ##
==========================================
- Coverage   98.39%   94.48%   -3.91%     
==========================================
  Files         150      187      +37     
  Lines       18063    24985    +6922     
==========================================
+ Hits        17773    23608    +5835     
- Misses        290     1377    +1087     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr changed the title Fix compat paths Bug fix: compatibility workflows Apr 26, 2024
@vincentmr vincentmr added the ci:build_wheels Activate wheel building. label Apr 26, 2024
@vincentmr vincentmr marked this pull request as ready for review April 26, 2024 13:15
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice job @vincentmr !

@vincentmr vincentmr merged commit 534a222 into master Apr 26, 2024
138 of 150 checks passed
@vincentmr vincentmr deleted the bugfix/ci_plugin_test_matrix branch April 26, 2024 13:44
@vincentmr
Copy link
Contributor Author

[sc-61920]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants