Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable gate dispatcher on x64 MacOS #697

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Apr 24, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: Due to intermittent failures on the CI, this PR disable the dynamic dispatcher on x64 MacOS builds of LightningQubit.

Description of the Change: As above.

Benefits: Ensures successful builds of the packages for testing and validation across ecosystem.

Possible Drawbacks:

Related GitHub Issues:

@mlxd
Copy link
Member Author

mlxd commented Apr 24, 2024

[sc-61797]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@mlxd mlxd added the ci:build_wheels Activate wheel building. label Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (43f7a91) to head (cc122b2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #697      +/-   ##
==========================================
+ Coverage   98.58%   98.67%   +0.09%     
==========================================
  Files         174      174              
  Lines       22629    22629              
==========================================
+ Hits        22309    22330      +21     
+ Misses        320      299      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlxd mlxd requested a review from a team April 24, 2024 17:01
@mlxd mlxd marked this pull request as ready for review April 24, 2024 17:01
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too! But isn't this change going to disable the dispatcher on all MacOS platforms (not just x64)?

@mlxd
Copy link
Member Author

mlxd commented Apr 24, 2024

LGTM too! But isn't this change going to disable the dispatcher on all MacOS platforms (not just x64)?

There's no dispatcher support on anything but x64, so it won't affect the ARM builds in any way, so I think it's fine. If we intend to add ARM intrinsics later, we'll need to restructure the dispatcher anyway, so that's probably the best time to re-evaluate.

@vincentmr
Copy link
Contributor

LGTM too! But isn't this change going to disable the dispatcher on all MacOS platforms (not just x64)?

There's no dispatcher support on anything but x64, so it won't affect the ARM builds in any way, so I think it's fine. If we intend to add ARM intrinsics later, we'll need to restructure the dispatcher anyway, so that's probably the best time to re-evaluate.

Ah, yes, of course. All good then.

@mlxd
Copy link
Member Author

mlxd commented Apr 24, 2024

Thanks @vincentmr and @jay-selby

@mlxd mlxd merged commit 4a08cdf into master Apr 24, 2024
82 checks passed
@mlxd mlxd deleted the disable_dispatcher_macos_x64 branch April 24, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants