Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native mcm workflow following dynamic_one_shot refactor. #694

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Apr 23, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:
[sc-61844]

@vincentmr vincentmr changed the base branch from master to pw-reorder April 23, 2024 21:55
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (296ea6d) to head (13a309f).

Additional details and impacted files
@@              Coverage Diff               @@
##           pw-reorder     #694      +/-   ##
==============================================
+ Coverage       95.49%   98.67%   +3.17%     
==============================================
  Files             174      174              
  Lines           22616    22629      +13     
==============================================
+ Hits            21598    22330     +732     
+ Misses           1018      299     -719     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr requested review from mlxd and removed request for mudit2812 April 23, 2024 21:58
@vincentmr vincentmr marked this pull request as ready for review April 23, 2024 22:02
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vincentmr! 🦅

@maliasadi maliasadi merged commit 5bd3134 into pw-reorder Apr 24, 2024
65 checks passed
@maliasadi maliasadi deleted the feature/dynamic_samples branch April 24, 2024 00:50
maliasadi added a commit that referenced this pull request Apr 24, 2024
* port PR changes so far, after traumatic rebase

* update vjp tests

* format

* update vjp tests

* update dev version

* format

* add tests for vjp

* Auto update version

* Auto update version

* Updated tests

* Updated serialization

* Unpinned cmake

* Update changelog

* Update .github/CHANGELOG.md

* isort

* black

* Run CI with updated PL branch

* Auto update version

* trigger ci

* Added changes per review

* Auto update version

* Update requirements-dev.txt

* Update pennylane_lightning/core/_serialize.py

Co-authored-by: Ali Asadi <[email protected]>

* Auto update version

* Trigger CI

* Update overlapping wires prod serialization test

* Updated tests to work with new pauli word order

* Added device_vjp tests

* Update serialize tests

* Auto update version

* Skipped tf test

* Auto update version

* Auto update version

* Trigger CI

* Updated torch test

* Update serialization tests; removed xfail

* Trigger CI

* Auto update version

* Remove vjp tests

* Trigger CI

* Trigger CI

* [skip ci] Revert requirements file

* Auto update version from '0.36.0-dev35' to '0.36.0-dev36'

* Trigger CI

* Trigger CI

* Fix native mcm workflow following dynamic_one_shot refactor. (#694)

* Fix native mcm workflow following dynamic_one_shot refactor.

* Auto update version from '0.36.0-dev35' to '0.36.0-dev36'

* Update changelog.

---------

Co-authored-by: ringo-but-quantum <[email protected]>

---------

Co-authored-by: AmintorDusko <[email protected]>
Co-authored-by: Amintor Dusko <[email protected]>
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: ringo-but-quantum <[email protected]>
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants