Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compile-time support for AVX2/512 streaming operations in LQ #664

Merged
merged 28 commits into from
Apr 25, 2024

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Mar 27, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: This PR enable compile-time support for AVX2/512 streaming operations, as validated and used for the Lightning paper workloads listed in https://github.com/PennyLaneAI/lightning-on-hpc and was promised for release in 0.36

Description of the Change: Adds compile-time support for streaming intrinsics to bypass cache-level updates.

Benefits: Improves performance for multithreading intrinsic-enabled kernels using high thread-counts.

Possible Drawbacks:

Related GitHub Issues:

[sc-62009]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 98.67%. Comparing base (5feb4a1) to head (5b43dbe).

Files Patch % Lines
...bit/gates/cpu_kernels/avx_common/AVX512Concept.hpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #664      +/-   ##
==========================================
+ Coverage   98.01%   98.67%   +0.65%     
==========================================
  Files         187      174      -13     
  Lines       24977    22607    -2370     
==========================================
- Hits        24482    22307    -2175     
+ Misses        495      300     -195     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlxd mlxd marked this pull request as ready for review March 27, 2024 18:36
@mlxd mlxd added the ci:build_wheels Activate wheel building. label Mar 28, 2024
@mlxd mlxd requested a review from vincentmr April 19, 2024 20:14
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me @mlxd. I'm leaving a few suggestions, but it is pretty much ready to merge IMO.

@mlxd mlxd requested a review from vincentmr April 24, 2024 14:38
@mlxd mlxd requested a review from AmintorDusko April 24, 2024 14:38
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice one @mlxd .

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mlxd! 💯

.github/workflows/tests_linux.yml Show resolved Hide resolved
@mlxd mlxd mentioned this pull request Apr 25, 2024
5 tasks
@mlxd mlxd merged commit 6260d59 into master Apr 25, 2024
80 of 81 checks passed
@mlxd mlxd deleted the feature/avx_streaming_ops branch April 25, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants