LightningQubit VJP support
#644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[sc-59045] |
albi3ro
reviewed
Mar 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #644 +/- ##
==========================================
+ Coverage 98.39% 98.66% +0.27%
==========================================
Files 172 172
Lines 25138 24376 -762
==========================================
- Hits 24734 24051 -683
+ Misses 404 325 -79 ☔ View full report in Codecov by Sentry. |
|
Lots of test failures in Pennylane due to lack of VJP support in Lightning. I am skipping such tests for now, but they should stop being skipped once this PR is merged. See the files changed in PL #5434 to find which tests need to be updated. |
|
TODO in pennylane: Uncomment interface tests using |
mudit2812
commented
Apr 3, 2024
vincentmr
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This PR adds adjoint VJP computation support to
lightning.qubitwith the new API.Description of the Change:
LightningQubit.compute_vjp,supports_vjp, andexecute_and_compute_vjpmethods along with appropriate helper functions.tests/test_vjp.pyto stop skipping new API devices.tests/new_api/test_device.py.Benefits:
LightningQubitcan now set thedevice_vjpargument to automatically use the VJP pipeline for differentiation.Possible Drawbacks:
Related GitHub Issues: