Update device toml specs to schema 2 #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
mlxd
reviewed
Mar 13, 2024
vincentmr
reviewed
Mar 19, 2024
…pported in this device
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #642 +/- ##
===========================================
- Coverage 98.13% 57.20% -40.93%
===========================================
Files 193 16 -177
Lines 25443 1832 -23611
===========================================
- Hits 24968 1048 -23920
- Misses 475 784 +309 ☔ View full report in Codecov by Sentry. |
vincentmr
reviewed
Mar 25, 2024
Co-authored-by: Romain Moyard <[email protected]>
Co-authored-by: Romain Moyard <[email protected]>
|
I have run the lightning and kokkos cross-checks using the following components:
As far as I see, after a minor Catalyst fixup (the PR is linked above), all checks pass. |
dime10
reviewed
May 3, 2024
maliasadi
approved these changes
May 7, 2024
maliasadi
added
ci:build_wheels
sergei-mironov
pushed a commit
to PennyLaneAI/catalyst
that referenced
this pull request
May 24, 2024
**Context:** Transition to the quantum device config schema 2 **Description of the Change:** Solve a regarding toml schema 2 udpate in tests by switching our test custom devices from toml text manipulations to the device capability manipulations **Benefits:** * Tests no longer require toml text manipulations. * Tests now contain simple examples of custom devices. * toml-specific code is now locates in `catalyst.utils.toml`. **Possible Drawbacks:** **Related GitHub Issues:** PennyLaneAI/pennylane-lightning#642 --------- Co-authored-by: David Ittah <[email protected]>
sergei-mironov
pushed a commit
to PennyLaneAI/catalyst
that referenced
this pull request
May 30, 2024
**Context:** Transition to the quantum device config schema 2 **Description of the Change:** * Remove mentions of CPhase "gate" which happens to be a Python alias for ControlledPhaseShift. * Remove the Python-only Projector patch because we already have a relaxed validation procedure for observables * Relax operation validation by allowing kokkos device to declare C(GlobalPhase) which is a Python-only operation. **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** * PennyLaneAI/pennylane-lightning#642 - (related discussion) PennyLaneAI/pennylane-lightning#642 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Catalyst supports quantum device specification in a new format in addition to the existing one, supporting per-gate parameters.
Description of the Change: By this PR we update existing device specifications to the new format
Benefits: Per-gate properties allow device authors to query PL for certain behavior on programs (decomposition, adding quantum control, validation)
Possible Drawbacks:
Related GitHub Issues: