Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random coverage xml CI issues #635

Merged
merged 11 commits into from
Mar 13, 2024
Merged

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented Mar 8, 2024

Fix random coverage xml CI non-deterministic failures with ignoring "No source for code __init__,py". This shouldn't affect the coverage as __init__ only includes the package version.

[sc-58646]

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (bb9b144) to head (29ae7c3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
+ Coverage   95.91%   98.71%   +2.80%     
==========================================
  Files         146      172      +26     
  Lines       19609    24339    +4730     
==========================================
+ Hits        18808    24027    +5219     
+ Misses        801      312     -489     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maliasadi maliasadi marked this pull request as ready for review March 12, 2024 15:35
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @maliasadi .

@maliasadi maliasadi requested a review from mlxd March 12, 2024 18:15
@vincentmr vincentmr requested a review from tomlqc March 12, 2024 18:15
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that!

@maliasadi maliasadi merged commit 2c69c59 into master Mar 13, 2024
85 checks passed
@maliasadi maliasadi deleted the maa/fix-ci-codecov-failure branch March 13, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants