Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up make #634

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Tidy up make #634

merged 4 commits into from
Mar 12, 2024

Conversation

maliasadi
Copy link
Member

Tidy up Makefile! (I'm in the process of tidying up and addressing small issues while looking into different parts of the codebase.)

Copy link
Contributor

github-actions bot commented Mar 8, 2024

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (958bc36) to head (ebe030d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
+ Coverage   98.40%   98.71%   +0.31%     
==========================================
  Files         172      172              
  Lines       24845    24339     -506     
==========================================
- Hits        24448    24027     -421     
+ Misses        397      312      -85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@maliasadi maliasadi merged commit bb9b144 into master Mar 12, 2024
85 checks passed
@maliasadi maliasadi deleted the maa/up-makefile branch March 12, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants