-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.35.1_rc #633
v0.35.1_rc #633
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v0.35.0_release #633 +/- ##
===================================================
- Coverage 98.70% 97.43% -1.27%
===================================================
Files 169 203 +34
Lines 24020 29445 +5425
===================================================
+ Hits 23708 28689 +4981
- Misses 312 756 +444 ☔ View full report in Codecov by Sentry. |
@mlxd Yep, about time to add that label ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @vincentmr! Nice work here!
observable, shot_range=shot_range, bin_size=bin_size, counts=counts | ||
) | ||
if diagonalizing_gates: | ||
self.apply([qml.adjoint(g, lazy=False) for g in reversed(diagonalizing_gates)]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this lazy set to False
required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albi3ro suggested this change. The doc says
If lazy=False, operation-specific adjoint decompositions are first attempted.
which makes it more likely to give another "native" operation, instead of a nested operation class. So I think in essence this forces, for example, qml.Adjoint(qml.RX(0.1))
to qml.RX(-0.1)
instead of something fancier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Release v0.35.1 introduces more comprehensive testing for finite-shot execution. Some bugs that were uncovered are fixed in each backend.
Description of the Change:
Add finite-shot execution tests and correctly apply diagonalizing gates for observables that require it.
Benefits:
Possible Drawbacks:
Related GitHub Issues: