Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.35.1_rc #633

Closed
wants to merge 20 commits into from
Closed

v0.35.1_rc #633

wants to merge 20 commits into from

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Mar 8, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
Release v0.35.1 introduces more comprehensive testing for finite-shot execution. Some bugs that were uncovered are fixed in each backend.

Description of the Change:
Add finite-shot execution tests and correctly apply diagonalizing gates for observables that require it.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@vincentmr vincentmr changed the base branch from master to v0.35.0_release March 8, 2024 21:11
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 32.95455% with 59 lines in your changes are missing coverage. Please review.

Project coverage is 97.43%. Comparing base (ef0638a) to head (287027f).

Files Patch % Lines
...ane_lightning/lightning_kokkos/lightning_kokkos.py 3.33% 29 Missing ⚠️
...ylane_lightning/lightning_qubit/lightning_qubit.py 14.70% 29 Missing ⚠️
pennylane_lightning/core/lightning_base.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           v0.35.0_release     #633      +/-   ##
===================================================
- Coverage            98.70%   97.43%   -1.27%     
===================================================
  Files                  169      203      +34     
  Lines                24020    29445    +5425     
===================================================
+ Hits                 23708    28689    +4981     
- Misses                 312      756     +444     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr changed the title V0.35.1 rc v0.35.1_rc Mar 8, 2024
@mlxd mlxd added the ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request label Mar 11, 2024
@AmintorDusko AmintorDusko self-requested a review March 11, 2024 17:41
@vincentmr
Copy link
Contributor Author

@mlxd Yep, about time to add that label ;)

@AmintorDusko AmintorDusko marked this pull request as ready for review March 11, 2024 18:02
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vincentmr! Nice work here!

observable, shot_range=shot_range, bin_size=bin_size, counts=counts
)
if diagonalizing_gates:
self.apply([qml.adjoint(g, lazy=False) for g in reversed(diagonalizing_gates)])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this lazy set to False required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albi3ro suggested this change. The doc says

If lazy=False, operation-specific adjoint decompositions are first attempted.

which makes it more likely to give another "native" operation, instead of a nested operation class. So I think in essence this forces, for example, qml.Adjoint(qml.RX(0.1)) to qml.RX(-0.1) instead of something fancier.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@AmintorDusko AmintorDusko added do not merge Do not merge PR until this label is removed and removed ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge PR until this label is removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants