Add LightningAdjointJacobian to support lightning.qubit2 #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Christina Lee <[email protected]>
vincentmr
reviewed
Mar 7, 2024
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
vincentmr
approved these changes
Mar 7, 2024
mudit2812
reviewed
Mar 7, 2024
There was a problem hiding this comment.
Really nice work @AmintorDusko ! Some blocking comments below, would love to hear your thoughts. Please let me know if I've incorrectly assumed stuff in my comments below. Very excited to get this in. I will start integrating this into #607 so that it doesn't return dummy jacobians.
albi3ro
reviewed
Mar 8, 2024
albi3ro
reviewed
Mar 8, 2024
mudit2812
reviewed
Mar 8, 2024
albi3ro
reviewed
Mar 8, 2024
albi3ro
reviewed
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: This PR adds a new Python class
LightningAdjointJacobianbringing support to adjoint Jacobian and VJP calculation for thelightning.qubit2device.Description of the Change: The new class attaches itself with the calculated statevector and calculates the adjoint jacobian or VJP when requested.
Benefits:
Possible Drawbacks:
Related GitHub Issues: