-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LightningAdjointJacobian to support lightning.qubit2 #631
Conversation
Co-authored-by: Christina Lee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few suggestions, but mostly looks good to me.
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, let's merge @AmintorDusko !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work @AmintorDusko ! Some blocking comments below, would love to hear your thoughts. Please let me know if I've incorrectly assumed stuff in my comments below. Very excited to get this in. I will start integrating this into #607 so that it doesn't return dummy jacobians.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Context: This PR adds a new Python class
LightningAdjointJacobian
bringing support to adjoint Jacobian and VJP calculation for thelightning.qubit2
device.Description of the Change: The new class attaches itself with the calculated statevector and calculates the adjoint jacobian or VJP when requested.
Benefits:
Possible Drawbacks:
Related GitHub Issues: