Lightning qubit2 add measurements #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Christina Lee <[email protected]>
mudit2812
reviewed
Mar 5, 2024
There was a problem hiding this comment.
Thanks @vincentmr ! Nice implementation for probs and var. I left a few comments. I spotted one issue with testing that I've mentioned below as well.
vincentmr
force-pushed
the
lightning-qubit2-add-measurements
branch
from
6f09183
to
24976a9
Compare
AmintorDusko
reviewed
Mar 6, 2024
Co-authored-by: Amintor Dusko <[email protected]>
albi3ro
reviewed
Mar 6, 2024
Co-authored-by: Christina Lee <[email protected]>
AmintorDusko
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
Add
probsandvarsupport in the new device measurement module.Add parametrized tests, checkout single/double observable support.
Benefits:
Possible Drawbacks:
Related GitHub Issues: