Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jax Fix imports #619

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Jax Fix imports #619

merged 3 commits into from
Feb 27, 2024

Conversation

AmintorDusko
Copy link
Contributor

@AmintorDusko AmintorDusko commented Feb 27, 2024

Context: The last Jax update changed the way we import config.

Description of the Change: Updated the jax.config import

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.09%. Comparing base (8794191) to head (8c35187).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #619      +/-   ##
==========================================
+ Coverage   98.49%   99.09%   +0.60%     
==========================================
  Files         169      203      +34     
  Lines       24463    29419    +4956     
==========================================
+ Hits        24094    29153    +5059     
+ Misses        369      266     -103     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AmintorDusko AmintorDusko added the ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request label Feb 27, 2024
@AmintorDusko AmintorDusko marked this pull request as ready for review February 27, 2024 16:15
@AmintorDusko AmintorDusko requested a review from a team February 27, 2024 16:15
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@AmintorDusko AmintorDusko merged commit efb946a into master Feb 27, 2024
88 checks passed
@AmintorDusko AmintorDusko deleted the fix_jax_config branch February 27, 2024 16:52
@AmintorDusko
Copy link
Contributor Author

Thank you, @maliasadi and @vincentmr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants