Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Docker build cron job into two #600

Merged
merged 7 commits into from
Jan 29, 2024
Merged

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Jan 24, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
Split Docker build cron job into two for plugin-test-matrix reporting.

Description of the Change:
Also fix missing v in the latest Docker build cron job label.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@vincentmr vincentmr changed the title Ci/docker version fix Split Docker build cron job into two Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2716864) 98.52% compared to head (21bffe3) 98.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #600      +/-   ##
==========================================
+ Coverage   98.52%   98.67%   +0.14%     
==========================================
  Files         168      169       +1     
  Lines       24566    24308     -258     
==========================================
- Hits        24204    23985     -219     
+ Misses        362      323      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr marked this pull request as ready for review January 26, 2024 15:44
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that!

Copy link

@Alex-Preciado Alex-Preciado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Thank you so much @vincentmr 😎

@vincentmr vincentmr merged commit 8add857 into master Jan 29, 2024
83 of 84 checks passed
@vincentmr vincentmr deleted the ci/docker_version_fix branch January 29, 2024 15:24
@vincentmr
Copy link
Contributor Author

Build test and push docker images from CI [sc-49050]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants