Add LGPU-MPI cpp backend #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add PL_BACKEND_LIST * Update the support * Exclude Python bindings * Update HermitianObs name scope conflicts * Auto update version * Cleanup * Update CI to build and check C++ tests of multiple backends (Linux) * Update changelog * Update .github/workflows/tests_linux.yml Co-authored-by: Vincent Michaud-Rioux <[email protected]> * Apply code review suggestions * Update .github/workflows/tests_linux.yml Co-authored-by: Amintor Dusko <[email protected]> --------- Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com> Co-authored-by: Vincent Michaud-Rioux <[email protected]> Co-authored-by: Amintor Dusko <[email protected]>
* Update DefaultQubit to DefaultQubitLegacy * Update changelog * update pylint disable on fallback
vincentmr
reviewed
Oct 24, 2023
pennylane_lightning/core/src/algorithms/tests/mpi/Test_AdjointJacobianMPI.cpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/algorithms/tests/mpi/Test_AdjointJacobianMPI.cpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/measurements/tests/mpi/Test_MeasurementsBaseMPI.cpp
Outdated
Show resolved
Hide resolved
...ing/core/src/simulators/lightning_gpu/measurements/tests/mpi/Test_StateVectorCudaMPI_Var.cpp
Outdated
Show resolved
Hide resolved
...core/src/simulators/lightning_gpu/measurements/tests/mpi/Test_StateVectorCudaMPI_Measure.cpp
Outdated
Show resolved
Hide resolved
.../core/src/simulators/lightning_gpu/measurements/tests/mpi/Test_StateVectorCudaMPI_Expval.cpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/observables/ObservablesGPUMPI.hpp
Outdated
Show resolved
Hide resolved
...lightning/core/src/simulators/lightning_gpu/observables/tests/mpi/Test_ObservablesGPUMPI.cpp
Outdated
Show resolved
Hide resolved
mlxd
requested changes
Oct 24, 2023
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaBase.hpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaBase.hpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaMPI.hpp
Show resolved
Hide resolved
...core/src/simulators/lightning_gpu/measurements/tests/mpi/Test_StateVectorCudaMPI_Measure.cpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/utils/MPIManager.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/utils/MPI_helpers.hpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/utils/MPI_helpers.hpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_qubit/CMakeLists.txt
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaManaged.hpp
Show resolved
Hide resolved
vincentmr
approved these changes
Oct 24, 2023
mlxd
requested changes
Oct 24, 2023
There was a problem hiding this comment.
Thanks @multiphaseCFD
Last round of comments and suggestions, then happy to approve once they are resolved.
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaMPI.hpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaMPI.hpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaMPI.hpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaMPI.hpp
Outdated
Show resolved
Hide resolved
...ing/core/src/simulators/lightning_gpu/gates/tests/mpi/Test_StateVectorCudaMPI_Generators.cpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/observables/ObservablesGPUMPI.hpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/utils/MPIManager.hpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/utils/MPI_helpers.hpp
Show resolved
Hide resolved
mlxd
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: