Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stable Lightning version git pull in compat workflows #507

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Sep 26, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
The github actions fetch-tags option does not checkout all tags, which prevents checking out the stable Lightning copy.

Description of the Change:
Force fetch tags where needed.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@vincentmr vincentmr changed the title Force fetch tags since actions/checkout option doesn't seem to work. Fix stable Lightning version git pull in compat workflows Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8f744aa) 99.13% compared to head (0e1365e) 99.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #507   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files         142      142           
  Lines       16798    16798           
=======================================
  Hits        16652    16652           
  Misses        146      146           
Files Coverage Δ
pennylane_lightning/core/_version.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr requested a review from a team September 26, 2023 14:00
@vincentmr vincentmr marked this pull request as ready for review September 26, 2023 14:00
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick n easy --- thanks @vincentmr

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vincentmr vincentmr merged commit d0bf669 into master Sep 26, 2023
64 checks passed
@vincentmr vincentmr deleted the bugfix/compat-stable-stable branch September 26, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants