Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/docker #496

Merged
merged 40 commits into from
Sep 22, 2023
Merged

Feature/docker #496

merged 40 commits into from
Sep 22, 2023

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Sep 8, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
Some systems have messy environments which makes on-site deployment complicated. Docker is a solution to this issue.

Description of the Change:
Add Docker container utilities.

Benefits:
Easier deployment, visibility on DockerHub.

Possible Drawbacks:

Related GitHub Issues:

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (17812fb) 99.13% compared to head (fcc5a32) 99.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #496   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files         142      142           
  Lines       16798    16798           
=======================================
  Hits        16652    16652           
  Misses        146      146           
Files Changed Coverage Δ
pennylane_lightning/core/_version.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr marked this pull request as ready for review September 12, 2023 20:02
@vincentmr vincentmr requested review from a team September 12, 2023 20:03
@AmintorDusko AmintorDusko removed the request for review from a team September 13, 2023 11:58
.github/CHANGELOG.md Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/README.md Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
@vincentmr vincentmr requested a review from a team September 13, 2023 20:00
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had just a small suggestion, but overall looks pretty good!

docker/README.md Outdated Show resolved Hide resolved
@vincentmr vincentmr requested a review from a team September 18, 2023 14:18
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts

Makefile Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
@vincentmr vincentmr requested a review from mlxd September 22, 2023 18:34
@vincentmr vincentmr merged commit 8f744aa into master Sep 22, 2023
63 checks passed
@vincentmr vincentmr deleted the feature/docker branch September 22, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants