Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mid state prep #495

Merged
merged 7 commits into from
Sep 8, 2023
Merged

Feature/mid state prep #495

merged 7 commits into from
Sep 8, 2023

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Sep 7, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
SC-43708 demands supporting mid-circuit state prep ops. This is dealt with by qml.execute already.

Description of the Change:
Add mid-circuit state prep ops tests.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (44c3c0e) 99.09% compared to head (4798889) 99.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #495   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         142      142           
  Lines       16693    16693           
=======================================
  Hits        16542    16542           
  Misses        151      151           
Files Changed Coverage Δ
pennylane_lightning/core/_version.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@vincentmr vincentmr marked this pull request as ready for review September 8, 2023 14:27
@vincentmr vincentmr requested a review from a team September 8, 2023 14:27
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that!

@AmintorDusko AmintorDusko requested a review from a team September 8, 2023 14:28
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @vincentmr !

@vincentmr vincentmr merged commit 7461186 into master Sep 8, 2023
61 checks passed
@vincentmr vincentmr deleted the feature/mid_state_prep branch September 8, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants