Testing/gpu #494
Merged
Testing/gpu #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentmr
force-pushed
the
testing/gpu
branch
from
aec0e33
to
3a40df3
Compare
…ing into testing/gpu
mlxd
reviewed
Sep 22, 2023
AmintorDusko
reviewed
Oct 5, 2023
pennylane_lightning/core/src/simulators/lightning_kokkos/bindings/LKokkosBindings.hpp
Show resolved
Hide resolved
AmintorDusko
approved these changes
Oct 10, 2023
mlxd
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Awesome work @vincentmr
Does this mean we can use CUDA 12 with LKokkos now?
AmintorDusko
approved these changes
Oct 12, 2023
Yes. In fact, CUDA-12 is now required to compile L-Kokkos as it uses C++20 features (not just a CUDA-lib API like L-GPU). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
L-Kokkos supports GPU execution with CUDA-12 and L-GPU is on the verge of being merged into
pennylane-lightning. There are no GPU tests to back these backends however.Description of the Change:
fail-on-cache-miss).ENABLE_KOKKOSoption from doc.Benefits:
Possible Drawbacks:
Combining test and codecov builds might have issues due to AVX kernels (to be monitored).
Related GitHub Issues: