Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QubitStateVector => StatePrep + parametrize tests. #486

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Aug 25, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
Rename QubitStateVector as StatePrep in Lightning following recent changes in PennyLane PR#4450.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@vincentmr vincentmr marked this pull request as ready for review August 25, 2023 20:33
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #486 (e2fb941) into master (e7922ff) will decrease coverage by 0.85%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
- Coverage   97.22%   96.37%   -0.85%     
==========================================
  Files         142       23     -119     
  Lines       16420     1186   -15234     
==========================================
- Hits        15964     1143   -14821     
+ Misses        456       43     -413     
Files Changed Coverage Δ
pennylane_lightning/core/lightning_base.py 100.00% <ø> (ø)
pennylane_lightning/core/_serialize.py 100.00% <100.00%> (ø)
pennylane_lightning/core/_version.py 100.00% <100.00%> (ø)
...ane_lightning/lightning_kokkos/lightning_kokkos.py 94.07% <100.00%> (+0.09%) ⬆️
...ylane_lightning/lightning_qubit/lightning_qubit.py 92.54% <100.00%> (ø)

... and 131 files with indirect coverage changes

@multiphaseCFD
Copy link
Member

Thanks @vincentmr ! I guess we need to change LightningGPU to Lightning in the context above.

@vincentmr
Copy link
Contributor Author

Thanks @vincentmr ! I guess we need to change LightningGPU to Lightning in the context above.

Indeed. Done, thanks.

@vincentmr
Copy link
Contributor Author

FYI for Codecov, I have #485 drafted that should fix coverage.

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this powered through. Thanks @vincentmr

Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @vincentmr

@mlxd mlxd merged commit 9390940 into master Aug 25, 2023
58 of 59 checks passed
@mlxd mlxd deleted the feature/stateprep branch August 25, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants