Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure active return check doesn't break CI #483

Merged
merged 5 commits into from
Aug 24, 2023
Merged

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Aug 24, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #483 (043ccc8) into master (eade88c) will increase coverage by 3.73%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #483      +/-   ##
==========================================
+ Coverage   93.48%   97.22%   +3.73%     
==========================================
  Files         142      142              
  Lines       16420    16420              
==========================================
+ Hits        15350    15964     +614     
+ Misses       1070      456     -614     
Files Changed Coverage Δ
pennylane_lightning/core/_version.py 100.00% <100.00%> (ø)
...ane_lightning/lightning_kokkos/lightning_kokkos.py 93.97% <100.00%> (+90.36%) ⬆️
...ylane_lightning/lightning_qubit/lightning_qubit.py 92.54% <100.00%> (+89.01%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks

@vincentmr vincentmr merged commit e7922ff into master Aug 24, 2023
60 checks passed
@vincentmr vincentmr deleted the active_ret_update branch August 24, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants