Update CMake paths for dependent package use #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
mlxd
commented
Aug 21, 2023
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
========================================
Coverage 97.21% 97.22%
========================================
Files 141 142 +1
Lines 16280 16420 +140
========================================
+ Hits 15827 15964 +137
- Misses 453 456 +3
|
AmintorDusko
approved these changes
Aug 21, 2023
| @@ -21,6 +21,9 @@ | |||
|
|
|||
| ### Bug fixes | |||
|
|
|||
| * Update the CMake internal references to enable sub-project compilation with affecting the parent package. | |||
There was a problem hiding this comment.
I know why you did it, but I'm not getting what you meant by "with affecting the parent package.".
Could you maybe rephrase that?
There was a problem hiding this comment.
That was a hastily written message indeed. Let's push ahead for the GPU fixes, and I'll make it better for release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: Currently the new package design assumes that all use will be internal to the nested projects. This however prevents packages depending on Lightning, for example through the CMake FetchContent utility, as source directories are assumed to be top-level of the outer package only. This PR updates all Lightning CMake references from
CMAKE_SOURCE_DIRtopennylane_lightning_SOURCE_DIR, as discussed by https://cmake.org/cmake/help/v3.27/command/project.html#command:projectDescription of the Change: As above.
Benefits: Allows the repo to be used as a sub-package with CMake.
Possible Drawbacks:
Related GitHub Issues: