Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH actions #476

Merged
merged 5 commits into from
Aug 21, 2023
Merged

Fix GH actions #476

merged 5 commits into from
Aug 21, 2023

Conversation

AmintorDusko
Copy link
Contributor

@AmintorDusko AmintorDusko commented Aug 21, 2023

Context:
Some GH actions are failing. This PR will fix that.

Description of the Change:
Fix upload to PyPI actions and add a missing label for some Linux actions.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #476 (c84dcb0) into master (4933137) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #476   +/-   ##
=======================================
  Coverage   97.22%   97.22%           
=======================================
  Files         142      142           
  Lines       16420    16420           
=======================================
  Hits        15964    15964           
  Misses        456      456           
Files Changed Coverage Δ
pennylane_lightning/core/_version.py 100.00% <100.00%> (ø)

@AmintorDusko AmintorDusko marked this pull request as ready for review August 21, 2023 16:31
.github/workflows/wheel_linux_aarch64.yml Outdated Show resolved Hide resolved
.github/workflows/wheel_linux_aarch64.yml Outdated Show resolved Hide resolved
.github/workflows/wheel_linux_aarch64.yml Outdated Show resolved Hide resolved
.github/workflows/wheel_linux_ppc64le.yml Outdated Show resolved Hide resolved
.github/workflows/wheel_linux_ppc64le.yml Outdated Show resolved Hide resolved
.github/workflows/wheel_noarch.yml Outdated Show resolved Hide resolved
.github/workflows/wheel_noarch.yml Outdated Show resolved Hide resolved
.github/workflows/wheel_win_x86_64.yml Outdated Show resolved Hide resolved
.github/workflows/wheel_win_x86_64.yml Outdated Show resolved Hide resolved
pennylane_lightning/core/_version.py Outdated Show resolved Hide resolved
@AmintorDusko
Copy link
Contributor Author

Since we can observe that the upload-pypi actions are working just fine, I removed the testing.
Let me know your thoughts.

@vincentmr
Copy link
Contributor

I removed the testing.

I'm not sure I can see those mods? Do you mean CIBW_TEST_COMMAND and related steps?

@AmintorDusko
Copy link
Contributor Author

I removed the testing.

I'm not sure I can see those mods? Do you mean CIBW_TEST_COMMAND and related steps?

What I meant to say was that I removed the testing regarding the upload-pypi.
I removed comments to some lines that were enabling the upload to Pypi.

@AmintorDusko AmintorDusko requested a review from mlxd August 21, 2023 17:27
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In essence, we can't use matrix.os because of the OS version, right? Looks good to me, thanks @AmintorDusko

@AmintorDusko
Copy link
Contributor Author

In essence, we can't use matrix.os because of the OS version, right? Looks good to me, thanks @AmintorDusko

Partially yes, but more than this, matrix.os writes the OS name in a different capitalization scheme.

@mlxd mlxd merged commit 32b0c8f into master Aug 21, 2023
60 checks passed
@mlxd mlxd deleted the fix/monorepo_actions branch August 21, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants