-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement unified docs for Lightning Qubit and Kokkos #473
Conversation
…d Lightning Kokkos backends Co-authored-by: vincentmr <[email protected]>
Hello. You may have forgotten to update the changelog!
|
This work is still under development. I'm tagging you just for your information. |
Just a quick request, the setup.py file needs a brief update for PyPI rendering, with the following change:
|
Other things we discussed:
|
Docs are ready, I think I covered all the topics we (Tom and I) discussed. I needed to adapt here the request below because our packaging structure is different from PennyLane and such a scheme would not work. I would like to ask for a final round of review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve now, since I only have some questions and suggestions. This is a great (and important) job @AmintorDusko !
pennylane_lightning/core/src/simulators/lightning_kokkos/gates/GateFunctorsGenerator.hpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AmintorDusko!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go!
Context:
Adds single unified documentation for Lightning Qubit and Lightning Kokkos.
For reference:
https://docs.pennylane.ai/projects/lightning/en/latest/
https://docs.pennylane.ai/projects/lightning-kokkos/en/latest/
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: