Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Lightning Qubit and Lightning Kokkos backends in a single improved repository #472

Merged
merged 38 commits into from
Aug 21, 2023

Conversation

AmintorDusko
Copy link
Contributor

@AmintorDusko AmintorDusko commented Aug 15, 2023

Context: This PR creates an improved structure for the Lightning repository, and merges Lightning Qubit and Lightning Kokkos in a single repository.

Description of the Change:

Complete overhaul of repository code.

  • New modular build system.
  • New device-agnostic and device-specific code separation, with code reuse between backends.
  • New partial C++ tests with restricted build.
  • New setup build with namespace packaging.

Benefits:
All of them.

Possible Drawbacks:
Not aware of it.

Related GitHub Issues:

@AmintorDusko
Copy link
Contributor Author

The update dev version action will continue to fail because the script looks for the version in a single place and the _version.py file changed place. Not much to be done here.

@AmintorDusko
Copy link
Contributor Author

[sc-38802]

.github/workflows/wheel_macos_x86_64.yml Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
requirements-dev.txt Outdated Show resolved Hide resolved
doc/code/api/pennylane_lightning.LightningQubit.rst Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #472 (41fd729) into master (dfd715e) will decrease coverage by 2.70%.
The diff coverage is 94.80%.

@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
- Coverage   99.91%   97.22%   -2.70%     
==========================================
  Files          50      142      +92     
  Lines        4671    16420   +11749     
==========================================
+ Hits         4667    15964   +11297     
- Misses          4      456     +452     
Files Changed Coverage Δ
...asurements/tests/Test_StateVectorKokkos_Expval.cpp 100.00% <ø> (ø)
...surements/tests/Test_StateVectorKokkos_Measure.cpp 100.00% <ø> (ø)
.../measurements/tests/Test_StateVectorKokkos_Var.cpp 100.00% <ø> (ø)
...lightning_kokkos/observables/ObservablesKokkos.hpp 100.00% <ø> (ø)
...okkos/observables/tests/Test_ObservablesKokkos.cpp 100.00% <ø> (ø)
...lightning_kokkos/tests/Test_StateVectorLKokkos.cpp 100.00% <ø> (ø)
...ors/lightning_kokkos/utils/LinearAlgebraKokkos.hpp 100.00% <ø> (ø)
...ightning_kokkos/utils/tests/Test_LinearAlgebra.cpp 100.00% <ø> (ø)
...c/simulators/lightning_qubit/StateVectorLQubit.hpp 100.00% <ø> (ø)
...ators/lightning_qubit/StateVectorLQubitManaged.hpp 100.00% <ø> (ø)
... and 132 more

... and 9 files with indirect coverage changes

@AmintorDusko
Copy link
Contributor Author

Codecov is activated, and the upload pypi actions are present.
I will open the PR for review now, since it is extensive, while I work in parallel on what still needs to be done.

@AmintorDusko
Copy link
Contributor Author

I remember that docs and benchmarks will come in follow-up PRs.

@AmintorDusko AmintorDusko marked this pull request as ready for review August 16, 2023 19:03
@AmintorDusko AmintorDusko requested a review from a team August 16, 2023 19:04
.github/workflows/tests_linux.yml Outdated Show resolved Hide resolved
.github/workflows/wheel_linux_x86_64.yml Outdated Show resolved Hide resolved
.github/workflows/wheel_linux_aarch64.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions and suggestions, but look good to me.

.github/workflows/benchmarks.yml Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
Makefile Show resolved Hide resolved
requirements-dev.txt Show resolved Hide resolved
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the hard work here!
Approving, and overriding the dev version failure, which will be rectified upon merging this PR

Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go. Nice work tying all the strings together.

@mlxd mlxd merged commit 4933137 into master Aug 21, 2023
57 of 60 checks passed
@mlxd mlxd deleted the merge/monorepo branch August 21, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants