Skip to content

Commit

Permalink
sc-66351 auto onboard large runenrs (#774)
Browse files Browse the repository at this point in the history
**Context:**
This PR fixes an issue introduced as part of the previous pr #769 .

This issue was identified while trying to replicate an RC branch and
testing the workflows as part of #773.

**Description of the Change:**
- Added extra echo statements to see clearly the outcome of the workflow
if logic
- Removes quotes around the regex expression as that was making all
evaluations of the logic to go false.
- This issue did not arise in my previous testing but turned out to be a
mismatch in shell configuration between myself locally and github
actions. I was able to reproduce the bug locally and see that this
worked.

#773 worked as expected with the changes introduced in this PR.

Links:
-
https://github.com/PennyLaneAI/pennylane-lightning/actions/runs/9616650952/job/26526641408?pr=773#step:2:14
-
https://github.com/PennyLaneAI/pennylane-lightning/actions/runs/9616650967/job/26526641639?pr=773#step:2:14

**Benefits:**
Auto on-boarding tested and working with this fix.

**Possible Drawbacks:**

**Related GitHub Issues:**

---------

Co-authored-by: ringo-but-quantum <[email protected]>
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
  • Loading branch information
4 people authored Jun 21, 2024
1 parent edd4515 commit f097557
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .github/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@

### Bug fixes

* Fix regex matching issue with auto on-boarding of release candidate branch to using the large runner queue.
[(#774)](https://github.com/PennyLaneAI/pennylane-lightning/pull/774)

* Fix random CI failures for `lightning.tensor` python unit tests and ignore `lightning_tensor` paths.
[(#761)](https://github.com/PennyLaneAI/pennylane-lightning/pull/761)

Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/determine-workflow-runner.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ jobs:
RC_BRANCH_FORMAT_REGEX: v[0-9]+\.[0-9]+\.[0-9]+-rc[0-9]?
REPO_FULL_NAME: PennyLaneAI/pennylane-lightning
run: |
if [[ '${{ contains(github.event.pull_request.labels.*.name, 'urgent') }}' == 'true' || ('${{ github.event.pull_request.head.repo.full_name }}' == "$REPO_FULL_NAME" && "${{ github.event.pull_request.head.ref }}" =~ "$RC_BRANCH_FORMAT_REGEX") ]]; then
if [[ '${{ contains(github.event.pull_request.labels.*.name, 'urgent') }}' == 'true' || ('${{ github.event.pull_request.head.repo.full_name }}' == "$REPO_FULL_NAME" && '${{ github.event.pull_request.head.ref }}' =~ $RC_BRANCH_FORMAT_REGEX) ]]; then
echo "This job requires usage of the large runner group '$LARGE_RUNNER_GROUP_NAME'";
echo "runner_group=$LARGE_RUNNER_GROUP_NAME" >> $GITHUB_OUTPUT
else
echo "This job does not require usage of large runners ...";
fi
2 changes: 1 addition & 1 deletion pennylane_lightning/core/_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@
Version number (major.minor.patch[-label])
"""

__version__ = "0.37.0-dev45"
__version__ = "0.37.0-dev46"

0 comments on commit f097557

Please sign in to comment.