Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fw-tools/edge-testnet - add || true to google ping #64

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

JanneKiiskila
Copy link
Contributor

@JanneKiiskila JanneKiiskila commented Jun 24, 2024

It can fail and if it does that, the script execution will stop abruptly (which is not what we want).

Todos

  • Changelog updated
  • Run shellcheck or pysh-check before committing code - no more warnings than earlier (preferably less)
  • Will tag a proper release, if need be.
  • Will update required recipes/builds as well.
  • Will update also the versions to relevant places:
    • edge-info/edge-info has the version number (around line 37)
    • identity-tools/VERSION has the version number as well.

It can fail and if it does that, the script execution will stop
abruptly (which is not what we want).
@JanneKiiskila JanneKiiskila added bug Something isn't working edge-testnet labels Jun 24, 2024
@JanneKiiskila JanneKiiskila merged commit ec39768 into master Jun 24, 2024
7 checks passed
@JanneKiiskila JanneKiiskila deleted the edge-testnet-ping-err branch June 24, 2024 08:13
@JanneKiiskila JanneKiiskila self-assigned this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working edge-testnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants