Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CI more robust #62

Merged
merged 1 commit into from
May 31, 2024
Merged

Make CI more robust #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/pr-checker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ jobs:
runs-on: [ "self-hosted", "client" ]
steps:
- uses: actions/checkout@v4
- run: sudo apt-get update && sudo apt-get install -y shellcheck
- run: shellcheck --version
- name: Shellcheck fw-tools/edge-testnet
run: shellcheck fw-tools/edge-testnet
Expand Down Expand Up @@ -44,7 +45,7 @@ jobs:
steps:
- uses: actions/checkout@v4
# Install pyshcheck tooling
- run: sudo apt install -y pycodestyle pydocstyle black
- run: sudo apt-get update && sudo apt-get install -y pycodestyle pydocstyle black
# git instead of rules to use access token
- run: git config --global url."https://${{ secrets.ACCESS_TOKEN }}@github.com/".insteadOf "[email protected]:"
- run: git config --global url."https://${{ secrets.ACCESS_TOKEN }}@github".insteadOf "https://github"
Expand Down Expand Up @@ -75,7 +76,7 @@ jobs:
echo "Failed to run edge-testnet -d example.com"
exit 1
fi
- name: Check if it works with a custom domain & snap
- name: Check if it works with a custom domain & SNAP env defined
run: |
if ! SNAP=snap fw-tools/edge-testnet --domain -pr-tester.pdm-sandbox.io -s --skip443 --skiptcp; then
echo "Failed to run edge-testnet -d example.com with SNAP env defined"
Expand Down