Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edge-testnet - grep the right file in K8S case #56

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

JanneKiiskila
Copy link
Contributor

We are not grepping the right log file in the k8s case (copy paste bug).

Todos

  • Changelog updated
  • Run shellcheck or pysh-check before committing code - no more warnings than earlier (preferably less)
  • Will tag a proper release, if need be.
  • Will update required recipes/builds as well.
  • Will update also the versions to relevant places:
    • edge-info/edge-info has the version number (around line 37)
    • identity-tools/VERSION has the version number as well.

We are not grepping the right log file in the k8s case (copy paste
bug).

Update copyright years.
Copy link
Contributor

@jenia81 jenia81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JanneKiiskila JanneKiiskila merged commit d06a8ef into master Feb 19, 2024
7 checks passed
@JanneKiiskila JanneKiiskila deleted the k8s-return-code-check branch February 19, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants