Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request template #29

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# Pull Request Checklist

## Description

```
submitter: Please add a description of your PR here.
```

## Test plan

```
submitter: Write here a way to test your changes. What needs to be done to fully see the impact of your changes?
```

## Check list

```
submitter: Please update the list below. You can mark sections as `not applicable` if they are not applicable for this pull request.
When some check is not necessary for this PR then please state a reason why it can be omitted.
```

- [ ] pull request is targeting `dev` branch
- [ ] commits have been signed-off
- [ ] documentation has been updated
- [ ] build scripts and jenkins scripts have been updated
- [ ] new configuration has been documented
- [ ] necessary log entries have been added or updated
- [ ] tests have been updated

## Licensing

I hereby confirm and sign-off the work is of my original doing and adheres to the
[existing MIT license](https://github.com/PelionIoT/manifest-lmp-pelion-edge/blob/master/LICENSE) in this repository.

- [ ] confirm MIT license compliance