support capital letters in headers (#26)

Ignore capital letters in swagger headers
PayU · Feb 27, 2018 · 8801cf8 · 8801cf8
1 parent e56d143
commit 8801cf8
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 2 deletions.
diff --git a/src/middleware.js b/src/middleware.js
@@ -259,7 +259,7 @@ function buildParametersValidation(parameters) {
 
         const required = parameter.required;
         const source = typeNameConversion[parameter.in] || parameter.in;
-        const key = parameter.name;
+        const key = parameter.in === 'header' ? parameter.name.toLowerCase() : parameter.name;
 
         var destination = ajvParametersSchema.properties[source];
 

diff --git a/test/middleware-test.js b/test/middleware-test.js
@@ -573,6 +573,30 @@ describe('input-validation middleware tests', function () {
                     done();
                 });
         });
+        it('headers are in capital letters - should pass validation', function (done) {
+            request(app)
+                .get('/v1/capital')
+                .set('Capital-Letters', '1.0')
+                .expect(200, function (err, res) {
+                    if (err) {
+                        throw err;
+                    }
+                    expect(res.body.result).to.equal('OK');
+                    done();
+                });
+        });
+        it('headers are in lowercase letters - should pass validation', function (done) {
+            request(app)
+                .get('/v1/capital')
+                .set('capital-letters', '1.0')
+                .expect(200, function (err, res) {
+                    if (err) {
+                        throw err;
+                    }
+                    expect(res.body.result).to.equal('OK');
+                    done();
+                });
+        });
         it('missing header - should fail', function (done) {
             request(app)
                 .get('/v1/pets')

diff --git a/test/pet-store-swagger-with-base-path.yaml b/test/pet-store-swagger-with-base-path.yaml
@@ -158,6 +158,13 @@ paths:
           description: unexpected error
           schema:
             $ref: '#/definitions/Error'
+  /capital:
+    get:
+      parameters:
+        - $ref: '#/parameters/CapitalLetters'
+      responses:
+        "200":
+          description: An paged array of pets
 definitions:
   Pet:
     required:
@@ -210,4 +217,9 @@ parameters:
     description: 'global request id through the system.'
     type: string
     minLength: 1
-    x-example: '123456'
+    x-example: '123456'
+  CapitalLetters:
+    name: 'Capital-Letters'
+    in: header
+    required: true
+    type: string
diff --git a/test/test-simple-server-with-base-path.js b/test/test-simple-server-with-base-path.js
@@ -16,6 +16,9 @@ module.exports = inputValidation.init('test/pet-store-swagger-with-base-path.yam
         app.post('/v1/pets', inputValidation.validate, function (req, res, next) {
             res.json({ result: 'OK' });
         });
+        app.get('/v1/capital', inputValidation.validate, function (req, res, next) {
+            res.json({ result: 'OK' });
+        });
 
         app.use('/v1', router);