Minor refactoring for IDE warnings (strimzi#10692)

Signed-off-by: Paolo Patierno <[email protected]>
PaulRMellor · Oct 10, 2024 · 63a2fd4 · 63a2fd4
1 parent 714df88
commit 63a2fd4
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/...in/java/io/strimzi/operator/cluster/operator/assembly/KafkaRebalanceAssemblyOperator.java b/...in/java/io/strimzi/operator/cluster/operator/assembly/KafkaRebalanceAssemblyOperator.java
@@ -146,13 +146,13 @@ public class KafkaRebalanceAssemblyOperator
 
     private static final ReconciliationLogger LOGGER = ReconciliationLogger.create(KafkaRebalanceAssemblyOperator.class.getName());
 
-    protected static final String BROKER_LOAD_KEY = "brokerLoad.json";
+    /* test */ static final String BROKER_LOAD_KEY = "brokerLoad.json";
     private final CrdOperator<KubernetesClient, KafkaRebalance, KafkaRebalanceList> kafkaRebalanceOperator;
     private final CrdOperator<KubernetesClient, Kafka, KafkaList> kafkaOperator;
     private final SecretOperator secretOperations;
     private final LabelSelector kafkaSelector;
     private final ConfigMapOperator configMapOperator;
-    private int cruiseControlPort;
+    private final int cruiseControlPort;
 
     /**
      * @param vertx The Vertx instance
@@ -420,8 +420,7 @@ && rawRebalanceAnnotation(kafkaRebalance) == null) {
     }
 
     private KafkaRebalanceStatus buildRebalanceStatusFromPreviousStatus(KafkaRebalanceStatus currentStatus, Set<Condition> validation) {
-        List<Condition> conditions = new ArrayList<>();
-        conditions.addAll(validation);
+        List<Condition> conditions = new ArrayList<>(validation);
         Condition currentState = KafkaRebalanceUtils.rebalanceStateCondition(currentStatus);
         conditions.add(currentState);
         return new KafkaRebalanceStatusBuilder()