Skip to content

Commit

Permalink
1.4.167.2
Browse files Browse the repository at this point in the history
Fix crash related to Oni-Goroshi
Fix crash related to number of brands attached to enemy
Fix parsing for One With Nothing Cluster Jewel
Fix increased effect of small passive skills applying to notables
  • Loading branch information
LocalIdentity committed Mar 23, 2020
1 parent 5d49ad2 commit 848e9bc
Show file tree
Hide file tree
Showing 7 changed files with 24 additions and 13 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
### 1.4.167.2 - 2020/03/24
* Fix crash related to Oni-Goroshi
* Fix crash related to number of brands attached to enemy
* Fix parsing for One With Nothing Cluster Jewel
* Fix increased effect of small passive skills applying to notables
### 1.4.167.1 - 2020/03/23
* Update uniques with changes from 3.10
* Add support for Arcane Cloak, Spellslinger, and Archmage Support
Expand Down
2 changes: 1 addition & 1 deletion Classes/PassiveSpec.lua
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,7 @@ function PassiveSpecClass:BuildSubgraph(jewel, parentSocket, id, upSize)
node.linked = { }
node.power = { }
self.tree:ProcessNode(node)
if node.modList and jewelData.clusterJewelIncEffect then
if node.modList and jewelData.clusterJewelIncEffect and node.type == "Normal" then
node.modList:NewMod("PassiveSkillEffect", "INC", jewelData.clusterJewelIncEffect)
end
end
Expand Down
4 changes: 2 additions & 2 deletions Data/3_0/ModCache.lua
Original file line number Diff line number Diff line change
Expand Up @@ -4739,7 +4739,7 @@ c["Adds 5 to 10 Fire Damage to Attacks with Bows"]={{[1]={flags=131076,keywordFl
c["Regenerate 1.4% of Life per second"]={{[1]={flags=0,keywordFlags=0,name="LifeRegenPercent",type="BASE",value=1.4}},nil}
c["4% chance to Dodge Spell Hits"]={{[1]={flags=0,keywordFlags=0,name="SpellDodgeChance",type="BASE",value=4}},nil}
c["+69 to maximum Energy Shield"]={{[1]={flags=0,keywordFlags=0,name="EnergyShield",type="BASE",value=69}},nil}
c["While in Her Embrace, take 0.5% of your total Maximum Life and Energy Shield as Fire Damage per second per Level"]={{[1]={[1]={[1]=200,stat="Life",type="PerStat"},[2]={type="Multiplier",var="Level"},[3]={type="Condition",var="HerEmbrace"},flags=0,keywordFlags=0,name="FireDegen",type="BASE",value=1},[2]={[1]={[1]=200,stat="EnergyShield",type="PerStat"},[2]={type="Multiplier",var="Level"},[3]={type="Condition",var="HerEmbrace"},flags=0,keywordFlags=0,name="FireDegen",type="BASE",value=1}},nil}
c["While in Her Embrace, take 0.5% of your total Maximum Life and Energy Shield as Fire Damage per second per Level"]={{[1]={[1]={div=200,stat="Life",type="PerStat"},[2]={type="Multiplier",var="Level"},[3]={type="Condition",var="HerEmbrace"},flags=0,keywordFlags=0,name="FireDegen",type="BASE",value=1},[2]={[1]={div=200,stat="EnergyShield",type="PerStat"},[2]={type="Multiplier",var="Level"},[3]={type="Condition",var="HerEmbrace"},flags=0,keywordFlags=0,name="FireDegen",type="BASE",value=1}},nil}
c["+63 to maximum Energy Shield"]={{[1]={flags=0,keywordFlags=0,name="EnergyShield",type="BASE",value=63}},nil}
c["Clear Oil - Amber Oil - Golden Oil +8% to Damage over Time Multiplier for Poison 8% increased Attack Speed 10% chance to Poison on Hit with Attacks 16% increased Damage with Poison"]={nil,"Clear Oil - Amber Oil - Golden Oil +8% to Damage over Time Multiplier for Poison 8% increased Attack Speed 10% chance to Poison on Hit with Attacks 16% increased Damage with Poison "}
c["Teal Oil - Silver Oil - Silver Oil +10% to Cold Damage over Time Multiplier"]={nil,"Teal Oil - Silver Oil - Silver Oil +10% to Cold Damage over Time Multiplier "}
Expand Down Expand Up @@ -10261,7 +10261,7 @@ c["Requires Level 68, 194 Int"]={nil,"Requires Level 68, 194 Int "}
c["4% increased Attack Speed while holding a Shield"]={{[1]={[1]={type="Condition",var="UsingShield"},flags=1,keywordFlags=0,name="Speed",type="INC",value=4}},nil}
c["Clear Oil - Opalescent Oil - Opalescent Oil 24% increased Damage with Bows +200 to Evasion Rating 6% increased Movement Speed 24% increased Damage Over Time with Bow Skills 20% increased Cooldown Recovery Speed of Movement Skills"]={nil,"Clear Oil - Opalescent Oil - Opalescent Oil 24% increased Damage with Bows +200 to Evasion Rating 6% increased Movement Speed 24% increased Damage Over Time with Bow Skills 20% increased Cooldown Recovery Speed of Movement Skills "}
c["Projectile Attack Skills have 60% increased Critical Strike Chance"]={{[1]={[1]={skillType=1,type="SkillType"},[2]={skillType=3,type="SkillType"},flags=0,keywordFlags=0,name="CritChance",type="INC",value=60}},nil}
c["14 to 20 Added Attack Physical Damage per 10 Dexterity while you are Unencumbered"]={nil,"14 to 20 Added Attack Physical Damage per 10 Dexterity while you are Unencumbered "}
c["14 to 20 Added Attack Physical Damage per 10 Dexterity while you are Unencumbered"]={{[1]={[1]={div=10,stat="Dex",type="PerStat"},[2]={type="Condition",var="Unencumbered"},flags=0,keywordFlags=65536,name="PhysicalMin",type="BASE",value=14},[2]={[1]={div=10,stat="Dex",type="PerStat"},[2]={type="Condition",var="Unencumbered"},flags=0,keywordFlags=65536,name="PhysicalMax",type="BASE",value=20}},nil}
c["Clear Oil - Sepia Oil - Violet Oil 30% increased Evasion Rating 5% chance to Dodge Attack Hits while Phasing"]={nil,"Clear Oil - Sepia Oil - Violet Oil 30% increased Evasion Rating 5% chance to Dodge Attack Hits while Phasing "}
c["Recover 25% of Life and Mana when you use a Warcry 100% increased Warcry Duration 100% increased Warcry Cooldown Recovery Speed If you've Warcried Recently, you and nearby allies\nhave 10% increased Attack Speed"]={nil,"Recover 25% of Life and Mana when you use a Warcry 100% increased Warcry Duration 100% increased Warcry Cooldown Recovery Speed If you've Warcried Recently, you and nearby allies\nhave 10% increased Attack Speed "}
c["Amber Oil - Crimson Oil - Crimson Oil 6% increased Cast Speed"]={nil,"Amber Oil - Crimson Oil - Crimson Oil 6% increased Cast Speed "}
Expand Down
4 changes: 2 additions & 2 deletions Modules/ConfigOptions.lua
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ return {
end },
{ label = "Brand Skills:", ifSkillList = { "Armageddon Brand", "Storm Brand" } }, -- I barely resisted the temptation to label this "Generic Brand:"
{ var = "BrandsAttachedToEnemy", type = "count", label = "# of Brands attached to the enemy", ifSkillList = { "Armageddon Brand", "Storm Brand" }, apply = function(val, modList, enemyModList)
modList:NewMod("Multiplier:BrandsAttachedToEnemy", "BASE", m_min(val, 2))
enemyModList:NewMod("Multiplier:BrandsAttached", "BASE", m_min(val, 2))
modList:NewMod("Multiplier:BrandsAttachedToEnemy", "BASE", m_min(val, 2), "Config")
enemyModList:NewMod("Multiplier:BrandsAttached", "BASE", m_min(val, 2), "Config")
end },
{ label = "Dark Pact:", ifSkill = "Dark Pact" },
{ var = "darkPactSkeletonLife", type = "count", label = "Skeleton Life:", ifSkill = "Dark Pact", tooltip = "Sets the maximum life of the skeleton that is being targeted.", apply = function(val, modList, enemyModList)
Expand Down
5 changes: 3 additions & 2 deletions Modules/ModParser-3_0.lua
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ local formList = {
["adds (%d+)%-(%d+) (%a+) damage to attacks"] = "DMGATTACKS",
["adds (%d+) to (%d+) (%a+) attack damage"] = "DMGATTACKS",
["adds (%d+)%-(%d+) (%a+) attack damage"] = "DMGATTACKS",
["(%d+) to (%d+) added attack (%a+) damage"] = "DMGATTACKS",
["adds (%d+) to (%d+) (%a+) damage to spells"] = "DMGSPELLS",
["adds (%d+)%-(%d+) (%a+) damage to spells"] = "DMGSPELLS",
["adds (%d+) to (%d+) (%a+) spell damage"] = "DMGSPELLS",
Expand Down Expand Up @@ -1918,8 +1919,8 @@ local specialModList = {
["your spells are disabled"] = { flag("DisableSkill", { type = "SkillType", skillType = SkillType.Spell }) },
["strength's damage bonus instead grants (%d+)%% increased melee physical damage per (%d+) strength"] = function(num, _, perStr) return { mod("StrDmgBonusRatioOverride", "BASE", num / tonumber(perStr)) } end,
["while in her embrace, take ([%d%.]+)%% of your total maximum life and energy shield as fire damage per second per level"] = function(num) return {
mod("FireDegen", "BASE", 1, { type = "PerStat", stat = "Life", 100 / num }, { type = "Multiplier", var = "Level" }, { type = "Condition", var = "HerEmbrace" }),
mod("FireDegen", "BASE", 1, { type = "PerStat", stat = "EnergyShield", 100 / num }, { type = "Multiplier", var = "Level" }, { type = "Condition", var = "HerEmbrace" }),
mod("FireDegen", "BASE", 1, { type = "PerStat", stat = "Life", div = 100 / num }, { type = "Multiplier", var = "Level" }, { type = "Condition", var = "HerEmbrace" }),
mod("FireDegen", "BASE", 1, { type = "PerStat", stat = "EnergyShield", div = 100 / num }, { type = "Multiplier", var = "Level" }, { type = "Condition", var = "HerEmbrace" }),
} end,
["gain her embrace for %d+ seconds when you ignite an enemy"] = { flag("Condition:CanGainHerEmbrace") },
["when you cast a spell, sacrifice all mana to gain added maximum lightning damage equal to (%d+)%% of sacrificed mana for 4 seconds"] = function(num) return {
Expand Down
5 changes: 5 additions & 0 deletions changelog.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
[1.4.167.2][2020/03/24]
* Fix crash related to Oni-Goroshi
* Fix crash related to number of brands attached to enemy
* Fix parsing for One With Nothing Cluster Jewel
* Fix increased effect of small passive skills applying to notables
[1.4.167.1][2020/03/23]
* Update uniques with changes from 3.10
* Add support for Arcane Cloak, Spellslinger, and Archmage Support
Expand Down
12 changes: 6 additions & 6 deletions manifest.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<PoBVersion>
<Version number="1.4.167.1" />
<Version number="1.4.167.2" />
<Source part="program" url="https://raw.githubusercontent.com/LocalIdentity/PathOfBuilding/{branch}/" />
<Source part="tree" url="https://raw.githubusercontent.com/Openarl/PathOfBuilding/{branch}/" />
<Source part="tree-2_6" url="https://raw.githubusercontent.com/Openarl/PathOfBuilding/{branch}/tree-2_6.zip" />
Expand All @@ -14,7 +14,7 @@
<File name="UpdateCheck.lua" part="program" sha1="72b9bea1871e94a643e4471fd84bbedbc7810336" />
<File name="UpdateApply.lua" part="program" sha1="4f17937f2b37784e169a3792b235f2a0a3961e61" />
<File name="GameVersions.lua" part="program" sha1="4cf43ef67fe750c22e15c7a63d7f77cce7768dba" />
<File name="changelog.txt" part="program" sha1="843a0da381420af618b06896e22d99204548af51" />
<File name="changelog.txt" part="program" sha1="1e9720a8d11162a5573386b376782f5392278e73" />
<File name="Path of Building.exe" part="runtime" platform="win32" sha1="7e5a3242c9a4296dc8377feb4c9d824f3f0a3cc1" />
<File name="lua51.dll" part="runtime" platform="win32" sha1="7a973d3c0b5121e6aad0dcb9323be5b432fc63e7" />
<File name="SimpleGraphic.dll" part="runtime" platform="win32" sha1="d852ae6eafc9be62aa41d3cb74fb986d0e5b40e5" />
Expand Down Expand Up @@ -61,7 +61,7 @@
<File name="Classes/ModList.lua" part="program" sha1="2fa5f20b12a4b366dc4b28a2a873699b834766d6" />
<File name="Classes/ModStore.lua" part="program" sha1="0c8844bf3d943bd9ea5c441da733f1e403b31365" />
<File name="Classes/NotesTab.lua" part="program" sha1="cc7c5eff58c2868cdc7d4c1bf9a967aa8c448c9e" />
<File name="Classes/PassiveSpec.lua" part="program" sha1="1ad89feb8e073b22516400ff427a62fcf044a396" />
<File name="Classes/PassiveSpec.lua" part="program" sha1="675d5c121f461bf12a72747dac93a94c9f2fab65" />
<File name="Classes/PassiveSpecListControl.lua" part="program" sha1="ab46589aefb4be643f7c1e95ba52d7916128b865" />
<File name="Classes/PassiveTree.lua" part="program" sha1="65d18bc12c7be5cb31a3f01b7ee39372d50f9d78" />
<File name="Classes/PassiveTreeView.lua" part="program" sha1="2b1deccfb59b93f7374e1d888a8aef2c9d6bca43" />
Expand Down Expand Up @@ -153,7 +153,7 @@
<File name="Data/3_0/Gems.lua" part="program" sha1="88a81ba9df963e60716228ab51632e9b0717f18b" />
<File name="Data/3_0/Minions.lua" part="program" sha1="d5b0b42b42277038094432785b16dd41ae2760d5" />
<File name="Data/3_0/Misc.lua" part="program" sha1="0d0ff8a9b691c2daa94fd51c8a35f6a0771c39cf" />
<File name="Data/3_0/ModCache.lua" part="program" sha1="e2ba4e5c9c6039f28e979aff43b186ad7ea592c6" />
<File name="Data/3_0/ModCache.lua" part="program" sha1="83eee0c64cf58d219311a1a4dae7dee332690ab2" />
<File name="Data/3_0/ModFlask.lua" part="program" sha1="f7c3d168265f7b0ba7cf8da1268f59d014194867" />
<File name="Data/3_0/ModItem.lua" part="program" sha1="cb284db55fbaa6e1fd339dcc0a870cd7cfa71bce" />
<File name="Data/3_0/ModJewel.lua" part="program" sha1="2b9a1e5566eb69bb8851ba33eedc5c26339b6adf" />
Expand Down Expand Up @@ -225,12 +225,12 @@
<File name="Modules/CalcSetup.lua" part="program" sha1="5499c2f2190b1f25b22c16c1238ab7cf53beaffa" />
<File name="Modules/CalcTools.lua" part="program" sha1="ad095534e9fc900879b8793e937b5668d2d29aab" />
<File name="Modules/Common.lua" part="program" sha1="e4d05529cb3cb990b81a0f7a594898a3ce215003" />
<File name="Modules/ConfigOptions.lua" part="program" sha1="9ef611b11c63715b083779758017c3904f0280d7" />
<File name="Modules/ConfigOptions.lua" part="program" sha1="faa243c8f52b52d573411571281097eb88f1f64f" />
<File name="Modules/Data.lua" part="program" sha1="024dc87dcdd18c24879eedef187c8fd4626e7bd6" />
<File name="Modules/ItemTools.lua" part="program" sha1="45d7097da7232e9ff3a935f20ef1ee84a9a8dde7" />
<File name="Modules/Main.lua" part="program" sha1="f1489cca222d661040ea20762dcfa964119f3cba" />
<File name="Modules/ModParser-2_6.lua" part="program" sha1="40816503edfc2023a070491d4d69ae02032e2312" />
<File name="Modules/ModParser-3_0.lua" part="program" sha1="cc983862997f5315e054c0f939e1b61b1af90de2" />
<File name="Modules/ModParser-3_0.lua" part="program" sha1="41bad0e7162f9d9252602ac827ed218bd97ec8cc" />
<File name="Modules/ModTools.lua" part="program" sha1="2ce4f3b83db992a286bd92f3849d037d6dcc8db2" />
<File name="Modules/StatDescriber.lua" part="program" sha1="cb77b8c6931a5c4c4695fc66f222422365d19a73" />
<File name="Modules/PantheonTools.lua" part="program" sha1="ebe91a7d8f8444a6061acf4758da0e775cc8c314" />
Expand Down

0 comments on commit 848e9bc

Please sign in to comment.