Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old browser(s) support #114

Open
jakub791 opened this issue Aug 22, 2022 · 10 comments
Open

Old browser(s) support #114

jakub791 opened this issue Aug 22, 2022 · 10 comments

Comments

@jakub791
Copy link

Currently break_eternity code (except the typescript version) gets transpiled to ES5 (ES2009) compatible syntax, which I assume is done to keep backwards compatibility. But as far as I know, the only browser that dosen't support ES6 (ES2015) is Internet Explorer (and there was an official statement about the fact that it's no longer gonna be supported IIRC).
So my question is: do we really need to transpile the code to ES5 compatible syntax?

@Patashu
Copy link
Owner

Patashu commented Aug 23, 2022

I think I do this because break_infinity does this because Antimatter Dimensions tried to support Internet Explorer.

Contingent on a convincing argument that this is no longer necessary then I'm happy for it to be changed. Don't know the pros/cons of this decision right now.

Repository owner deleted a comment from pictureofhotdogplus Aug 26, 2022
@jakub791
Copy link
Author

You shouldn't even think about Internet Explorer.

@Patashu
Copy link
Owner

Patashu commented Aug 29, 2022

As long as people still use IE11, then surely it's not without value to support it.

@jakub791
Copy link
Author

jakub791 commented Aug 29, 2022

If they use 10 years old technology they should be aware of consequences.

@jakub791
Copy link
Author

jakub791 commented Aug 29, 2022

And also: even if you keep supporting IE11, game devs might not do it for the rest of the game code which defeats the point.

@jakub791
Copy link
Author

jakub791 commented Aug 29, 2022

All games that I know use at least some of ES6 syntax which isn't availabe in IE11

@James103
Copy link

From what I can tell, Microsoft Edge has IE11 compatibility mode; does that limit Javascript to ES5 like in the real IE11?
If so, then this may have to wait until IE11 compatibility mode is depreciated near the end of this decade (at the time of writing).

@jakub791
Copy link
Author

Tell me one game that is IE11 compatible.

@jakub791
Copy link
Author

jakub791 commented Aug 29, 2022

Oh also why is the ESM version of this library transpiled to ES5 syntax? ES modules aren't available in ES5 so.

@jakub791
Copy link
Author

As long as people still use IE11, then surely it's not without value to support it.

well ok, I get you. Still would be nice to have a separate modern build of the library for whose who don't need that - surely such code using native classes would run faster than the more verbose ES5 code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants