Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] break_eternity.js in source code #250

Open
xShadowBlade opened this issue Sep 5, 2024 · 0 comments
Open

[FEATURE] break_eternity.js in source code #250

xShadowBlade opened this issue Sep 5, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@xShadowBlade
Copy link
Owner

xShadowBlade commented Sep 5, 2024

Is your feature request related to a problem? Please describe.
Right now, break_eternity.js is included in this package by including the source code instead of using an npm package.

Describe the solution you'd like
The code can either stay the way as is (and also run prettier/other formatters on it), or break_eternity.js could be removed from the source.

Describe alternatives you've considered
N/A, see next section.

Additional context
(from README.md)
This was done in order to implement the saving/loading system using class-transformer and reflect-metadata, and you cannot import directly from break_eternity.js as the package targets a version of javascript (es5) that is not supported by class-transformer and reflect-metadata.

In addition, reflect-metadata doesn't work due to the nature of esbuild.

If an alternative method exists that doesn't include the source code in this package, then I will revisit this.

@xShadowBlade xShadowBlade added the enhancement New feature or request label Sep 5, 2024
xShadowBlade added a commit that referenced this issue Sep 6, 2024
@xShadowBlade xShadowBlade changed the title [FEATURE] Update to break_eternity.js v2.1.0 and break_eternity.js in source code [FEATURE] Break_eternity.js in source code Sep 6, 2024
@xShadowBlade xShadowBlade changed the title [FEATURE] Break_eternity.js in source code [FEATURE] break_eternity.js in source code Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant